1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/logfile.cpp mai

    From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/m on Tuesday, December 02, 2025 15:29:00
    https://gitlab.synchro.net/main/sbbs/-/commit/8fa0e5c5343c024191e76ce7
    Modified Files:
    src/sbbs3/logfile.cpp main.cpp newuser.cpp sbbs.h
    Log Message:
    Log more details during new user registration

    Include new user registration failure attempts in the system log files
    (i.e. data/logs/<date>.log) - this is done by adding a new state to sbbs_t user_login_state.

    Add more new user registration failure (reason) log messages. Updated other
    log messages, e.g. "Successful new user logon" becomes "Successful new user registration".

    More use of llprintf.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian L@VERT to Git commit to main/sbbs/m on Wednesday, May 06, 2026 19:41:00
    https://gitlab.synchro.net/main/sbbs/-/commit/7f4942380db1ab3a679d0c98
    Modified Files:
    src/sbbs3/logfile.cpp main.cpp
    Log Message:
    main,logfile: suppress nodefile_mutex inter-procedural FPs (CIDs 515594, 515595, 515596, 543172)

    Same root cause as the getnode.cpp CIDs already mitigated by the
    nodefile_mutex refactoring (mutex is now confined entirely to getnodedat/putnodedat, both of which lock+unlock atomically). The
    flagged sites in daily_maint, logoffstats, sbbs_t::errormsg, and the
    sbbs_t destructor never touch nodefile_mutex directly Ä Coverity is
    propagating phantom lock state through the helper-function call chain.

    CID 515594: smb_open_sub SLEEP in daily_maint
    CID 515595: errormsg LOCK in logoffstats
    CID 515596: errormsg LOCK at logfile.cpp function end
    CID 543172: js_cleanup SLEEP in sbbs_t destructor

    Annotate each site with a SUPPRESS pointing at the invariant.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net