• src/sbbs3/js_bbs.cpp

    From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/m on Saturday, December 23, 2023 16:55:00
    https://gitlab.synchro.net/main/sbbs/-/commit/9896f220e68d1b8379b08840
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Address cppcheck false positive

    error: Uninitialized struct member: node.misc [uninitStructMember]

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, February 06, 2024 15:35:50
    https://gitlab.synchro.net/main/sbbs/-/commit/90b93e4a1eb53532faca437a
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Support optional msg_header argument to bbs.expand_atcodes()

    For Nightfox's use in DDMsgReader.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 23, 2024 20:11:55
    https://gitlab.synchro.net/main/sbbs/-/commit/ec3f6c0d2baa5d9f90a3e70f
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix CID 486181: Resource leak (RESOURCE_LEAK)

    A couple of error paths in expand_atcodes() method could leak heap memory.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, August 08, 2024 13:23:25
    https://gitlab.synchro.net/main/sbbs/-/commit/0fbdf31cedaa84d4b674ecce
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Make argument to bbs.batch_clear() optional (clear downlaod queue by default)

    ... as appears to have been the intent

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, August 10, 2024 19:44:50
    https://gitlab.synchro.net/main/sbbs/-/commit/5a6714e3576a32a11106bae4
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix CIDs 508283 508284 508285 508286 508287

    HANDLE_PENDING() macro returns from the calling function (without freeing allocated resources), so don't use that here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, October 15, 2024 15:29:57
    https://gitlab.synchro.net/main/sbbs/-/commit/47eb42e6f96ba73d9146dc22
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add missing file to commit 095368c0d7

    Not sure how I missed this one, but this file was needed to complete the
    'bbs' object changes mentioned in that commit message.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, October 15, 2024 23:35:03
    https://gitlab.synchro.net/main/sbbs/-/commit/1df94b61610b47746fc56995
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix GCC warning (unused variable) introduced in last commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, October 25, 2024 21:07:02
    https://gitlab.synchro.net/main/sbbs/-/commit/9f27c430d8e5b7a89f181be7
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add bbs.download_cps, batch_sort(), and batch_remove()

    Helpful for a JS batch file transfer menu

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, October 27, 2024 22:00:26
    https://gitlab.synchro.net/main/sbbs/-/commit/3c86324d6fb20148b55bad17
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    New method: bbs.xtrn_prot_menu()

    So we don't have to reimplement this logic in user_settings.js (or
    equivalent) any longer.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, October 27, 2024 22:37:05
    https://gitlab.synchro.net/main/sbbs/-/commit/7f04c593a06de309e94c278c
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    bbs.xfer_prot_menu() now returns the list of protocol keys (mnemonics)

    ... that the user has access to

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, October 28, 2024 17:54:56
    https://gitlab.synchro.net/main/sbbs/-/commit/f50c866fd152678bde4c1083
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix CID 511447 with extra parens

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, November 09, 2024 20:30:54
    https://gitlab.synchro.net/main/sbbs/-/commit/c9ec49e0f40b8af1e975bf09
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix logic in bbs.xfer_prot_menu()

    This was just a typo which didn't allow the single-file upload xfer prot menu to be shown.

    Actual fix for CID 11447 (previous attempt, commit f50c866fd was
    insufficient). Thank you Coverity!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, November 30, 2024 01:45:10
    https://gitlab.synchro.net/main/sbbs/-/commit/52460c3abc163308c7be1c62
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Range check argc before deref of argv[1]

    Apparently JSVAL_IS_STRING() can return true even when argv[1] is out of range (I guess I assumed it'd alwasy be NULL or VOID/undefined) and this can lead to crash when calling JS_ValueToString() on it.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 09, 2024 19:15:31
    https://gitlab.synchro.net/main/sbbs/-/commit/6dbd2fec644cd1f153137bc2
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Support text.dat string IDs (string) args for replace/revert_text() funcs

    For alignment with the text() method and for instances where a script author doesn't want to load('text.js') or use [bbs|system].text.ID to get a text.dat string index from an ID.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, December 10, 2024 16:28:49
    https://gitlab.synchro.net/main/sbbs/-/commit/9f3d653e0cf46d0eacb2e0b2
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add missing space to JSDOC HTML output

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net