1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/xpdev/sockwrap.c

    From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/m on Monday, March 02, 2026 22:42:00
    https://gitlab.synchro.net/main/sbbs/-/commit/2773f92cddcec6b459d6a17b
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    nonblocking_connect() must return non-zero upon failure to connect

    on Windows, after the call to the socket_writable() timed out (failed)
    calling getsockopt(... SO_ERROR ...) was setting the result to 0, indicating a successful connection.

    So if getsockopt() reports the socket errno value is 0, don't use that value for the result, default to ETIMEDOUT (60) instead.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/m on Monday, March 02, 2026 22:53:00
    https://gitlab.synchro.net/main/sbbs/-/commit/05695d68d4d420b7b2f00dbc
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Fix Borland C compile error

    Yup, still using ancient tools to build xpdev

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/m on Monday, March 02, 2026 23:05:00
    https://gitlab.synchro.net/main/sbbs/-/commit/f0faf99aab62e7855c5de682
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Minimize the diff of these last couple of commits to nonblocking_connect()

    No functional change.

    We're not retaining the original conect() error value, so don't need the new/additional variable (and associated line changes).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/m on Tuesday, March 03, 2026 12:55:00
    https://gitlab.synchro.net/main/sbbs/-/commit/e77ef308c29867a147afce0e
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    getsockopt(... SO_ERROR...) should be called when writable

    Commit 01fc91c816 reversed this logic.

    Leaving the getsockopt() in the failure case for now in case the
    wirder range of results is useful somehow.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/m on Sunday, March 15, 2026 16:01:00
    https://gitlab.synchro.net/main/sbbs/-/commit/1543bdb9056f4e8432e0b895
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Fix addrinfo linked list traversal in xp_inet_pton()

    Same bug as netwrap.c Ä cur++ on an addrinfo linked list is undefined
    behavior since nodes are not contiguous. Use cur = cur->ai_next.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net