https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6376

typo: terminal

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6377

I'm not seeing the string Mode7TerminalQ used in the C++ source files, so we should remove this (if unused).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6378

Remove this line

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6379

I'm uneasy about all this copy-pasta. Now we've got 2 places that someone (me) has to update anytime we need to update these defaults. Please move to a common source file or .ini file or something.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6381

Similar to chat_sec.js, this is almost identical to exec/chat_sec.js, so let's merge the differences and get rid of this almost-identical copy/variant.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6380

This file looks almost identical to chat_sec.js, so let's merge the differences and get rid of this file.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6383

Delete extraneous white-space change.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6382

On second thought, this should be a module option. :-)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6385

Update comments

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6384

Delete extraneous white-space change.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6386

I'm thinking that yesnobar.js and noyesbar.js should use the same set of options from modopts.ini - so just pass "yesnobar" here.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6387

So this would be changed `options.yesno_question`

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6388

This function doesn't appear to do anything - so not needed?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6389

What are we using from mode7defs.h in this file?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6390

Is there a reason to over-ride the default_term_height here? Is a 24 row mode7 terminal just never possible?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6391

What are we using from mode7defs.h here?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6392

is .m7 the best file suffix/extension to use for BBC mode7 encoded files? I don't know, just curious/asking.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6393

I noticed this conversion isn't happening in the Windows version of this function, but it's not happening for PETSCII or UTF-8 either, so we'll have to deal with all 3 of those charset conversion together someday.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6394

Update comment.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6395

Typo

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6396

Remove cruft. :-)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6398

This file appears to be identical to system.msg just with the Ctrl-A codes stripped. If we're stripping Ctrl-A codes from display files already, why do we need this file (the result is the same)?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6397

Why's there a date in this file?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6399

Extraneous '/' in this string.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6400

Maybe "BBC" instead? It's a little weird the charset and the terminal type are the same string value.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6401

Something wonky here with tabs vs spaces.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6402

Something weird going on here with tabs vs. spaces.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6403

tabs vs spaces

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6404

tabs vs spaces

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6405

Nice! It could be merged as is but it'd be nice if it was cleaned-up a bit first.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6406

Now that I think about it... where is the change to ignore/strip Ctrl-A codes? I'm not seeing that.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6407

I see now, none of the values from mode7defs.h appear to be used, so I'm guessing this branch isn't as far along as I assumed. Hopefully the comments so far are at least helpful in some regard.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6408

Fixed at my end.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6409

This will be added per my comment. I've not finished the autoterm stuff where it goes through and asks what sort of terminal you're using. I wanted to put these in so you're aware of them when adding to text.dat.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6410

Removed. I can remove any others I come cross in the future since we're not longer using CVS.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6411

Yup, but if we can unify chat_sec.js, that becomes N/A anyway.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/499#note_6412

OK. I will have to think about how I want to do that. I'll put it on my todo list.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net