https://gitlab.synchro.net/main/sbbs/-/commit/1994a535b8c0e688e8a139fc
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log error on final channel message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7df6956da2b4246a9ca3940e
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log an error if there's QWKnet sub pointer value to be read

This partially reverts commit 44c3350f where a bunch of read() and write() return value checking was added.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bac2285755b0eda8a209e365
Modified Files:
src/sbbs3/main.cpp
Log Message:
Another fix for the read() reutrn value FORTIFY warning

that doesn't log an error

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a8374b52cbc57902bb303d7e
Modified Files:
src/sbbs3/main.cpp
Log Message:
second part of commit 0b1b1a6f

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e53f173153fdaf0341cca95c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove unnecessary call to DuplicateHandle() in Win32 builds of sbbs_t::init()

The client_socket_dup is overwritten after with the return value of accept(), so this was likely a socket/handle leak (since commit 74470573, 17 years ago).

Noticed this only after logging a new error in an SSH connection when this
call to DuplicateHandle() failed for some reason (WinError 6), but it seems like it's been redundant code for a long time now. So just ace it and possibly fix a resource leak.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/346a2d304c7d921d656489ad
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the socket descriptor and protocol when getsockname() fails

This is a new error that just started cropping up. I suspect it's related to recent SSH changes. This might help a little with context, when it happens again.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/af7852df11093dc6ed559f64
Modified Files:
src/sbbs3/main.cpp
Log Message:
Ignore remove() return value purposefully in this case.

Does this resolve Coverity warning? I don't rember.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2b2d8289b92d7f6e6faa1633
Modified Files:
src/sbbs3/main.cpp
Log Message:
More time_t printf fun.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1e734d10425f7ca7fb239931
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove line that was commented-out 14 years ago

Commit d1182efc

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0a6c1f00de9e4457f598b4f4
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning if failed to write to spy ring buffer

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4fa2aa66fda6be0ef693f512
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log an error if spy socket write return EPIPE (expected)

Also, resove a new gcc warning about signed/unsigned compares.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a474017fb7c51f91ef9c4095
Modified Files:
src/sbbs3/main.cpp
Log Message:
sbbs_t::incom() should return NOINP immediately if/when socket disconnected

JS console.inkey() and friends use this as the underlying function to get
input from the TCP socket.

This might address issue #725

Hoping Nelgin will let us know.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4c893720f8e0c57753b08a91
Modified Files:
src/sbbs3/main.cpp
Log Message:
Attempt to fix error nelgin reported with ssh session timeouts

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e4adbcb541c6f7139e63d2ca
Modified Files:
src/sbbs3/main.cpp
Log Message:
Prevent the input thread from closing channel that has a session,
but does not yet have a session type.

Also, fix what appears to be a fairly blatant memory leak.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/346849ac253a08374b9bfca0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Unlock ssh_mutex before calling sftps_recv()

This should fix the sftp hangs...
While FreeBSD will return EDEADLOCK when a mutex would deadlock,
Linux will do what I ask and deadlock.

Since we're not checking the return value of pthread_mutex_lock(),
this would go completely unnoticed on FreeBSD, resulting in the
mutex being unlocked early and all sorts of unprotected accesses
would happen, potentially doing crazy things. On Linux it just
deadlocks, and taking a peek at the thread backtraces makes the
problem obvious.

So, point to Linux for making life more correct for people who
do incorrect things (locking without checking the return value).

I'd also like to thank nelgin, for sticking with me on this issue
and being my gdb puppet.

And really, this commit should be shared by all the contributors
who... ¨¨¨¨

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c846776318dc4ca28946083c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Break stuff to test things.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/eddcfe2f9b10d250d16a6c7f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Now unbreak!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/be8603b11bd6cf12c6f74256
Modified Files:
src/sbbs3/main.cpp
Log Message:
Replace (and auto-upgrade) ctrl/time.dab with time.ini

This will allow us to change scfg_t.event[].last to a time_t value (from time32_t) whenever we abandon Borland C/C++ in the future.

Now it's trival for sysops to view/edit when their timed events 'last run' values. And there's no more endianness concerns. Bad .dab files, bad, go away.

After I wrote this change, I found the original conversion code in v4upgrade.c which is almost exactly the same (except I was going to write to different filename). Finally actually implemented this. Next up: qnet.dab

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/03be991a6f30b98ae9c0320b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Convert (and auto-upgrade) ctrl/qnet.dab to ctrl/time.ini as well

I suppose this should've been part of the previous commit.

Again, this is almost verbatim what v4upgrade.c did (though never actually used).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/19ab720de38838ae2e4e1154
Modified Files:
src/sbbs3/main.cpp
Log Message:
Resolve recently introduced warnings about const char* to char* conversion

C++ <sigh>

We don't need a .ini section separator anyway.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/00a80d45d884c9ab547fef31
Modified Files:
src/sbbs3/main.cpp
Log Message:
exec/*.bin cmd shell filenames were case sensitive (must've been lowercase)

... while the mods/*.bin command shell filenames could be any-case!

Only impacted non-Windows systems (UNIX file systems are case-sensitive).

Discovered while making this tutorial video: https://youtu.be/HlwQ0uX4S04

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76b5c7f4399c7774c368c754
Modified Files:
src/sbbs3/main.cpp
Log Message:
Resolve CID 492287 - we don't care about the fexistcase() return value here

We're just using it to "fix" the case, if the file indeed exists.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6713d10cb1f9e44d1cb8a9e6
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix incorrect 'socket' value for new (highwater) log message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/06f6b07ddbc0ba9f7d66f5c5
Modified Files:
src/sbbs3/main.cpp
Log Message:
Eliminate large-scoped 'i' variable in bbs_thread()

This is just a code quality (readability) improvement. No functional change.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/59e30dda6bb683b9c1a97298
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix *nix build

We removed the large-scope 'i', but didn't update the Unix-only blocks of code (dealing with UNIX domain spy sockets).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bca9510b25f790f84f59545a
Modified Files:
src/sbbs3/main.cpp
Log Message:
Include current node number intead of socket descriptor in highwater log msg

looks better, more consistent with the log messages before/after it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c03ed4b9ce042d5651575e18
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning if any socket inactivity max durations are shorter/equal to ...

to the getkey inactivity timeout.

By setting a socket timeout shorter or equal to the getkey timeout, the getkey timeout effectively does nothing.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2ce9ccfe50ab05c3bacf2e8d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Reset sbbs_t menu path vars (menu_dir and menu_file) before execing cmd shell

I obvserved an issue with Amessyroom's bbs where his custom (JS) shell is setting bbs.menu_dir but when switching to another stock shell, his menu
files were still being displayed (with mismatching command keys as a result).

bbs.menu_dir (and implicitly, the set_menu_dir Baja function) apparently have not been used in this way (much) before.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ccab84c359406ffea9695db3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/27e30f1277531509630d3ca8
Modified Files:
src/sbbs3/main.cpp
Log Message:
Better support for multiple hosts handling QWK events

First, fix the logged username bug in the "Lock exists" log message.
Next, double check that the trigger file (sem file or REP file) still exists after acquiring the file mutex.

Use a temp varible (fname) to make the code easier to read.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5956805f6e2e985824a86d52
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log event command-lines (repeating event code was redundant)

Only log messages about QWK mutex files existing when > 60 seconds old

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3127e4f4b89c73263cadd901
Modified Files:
src/sbbs3/main.cpp
Log Message:
Detect hung event_thread and log details

Add log message when spawning background timed event

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6df88451e8d9ce67c27bd4d0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use timestr() instead of ctime_r() for logging full date/times

Also when detecting a blocked event_thread, log the event_code that is/was running last.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/87b22bda88174a8e03e25558
Modified Files:
src/sbbs3/main.cpp
Log Message:
Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

glob() results might be out of date by the time we look at each file, just
skip missing QWK pack semaphore files silently. This should resolve the
".now already gone" messages too. Hopefully.

Removed some extraneous quotes around logged event command-lines.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f37e9789f42d73d4991d2ff3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use fmutex_open() instead of fmutex() to better protect the pack*.lock files

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6dda18740c154c5f099070d1
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use fmutex_close() and don't log ENOENT errors when removing pack*.now files

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/208f263b94e85ef91dc62cc3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Just a little wording update on the fmutex file open log message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2fa8db2b6a1a5da43db71887
Modified Files:
src/sbbs3/main.cpp
Log Message:
Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

This condition caused aborting BBS operations via Ctrl-C to fail when connecting from a traditional Telnet client using binary transmission
mode (e.g. telnet -8) or SyncTERM v1.2rc6.

The check of rio_abortable was probably enough to disable this function
during file transfers (e.g. we've had no issues with SSH file transfers
that might include byte 0x03 received from the client), but I added the
check for SS_FILEXFER system status check too, perhaps unnecessary.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6d7f85680177ba6fef1946f2
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't use uninitialized variable: lockfname

Where's the compiler warnings guys?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fa5321fe8850f6d2d9558312
Modified Files:
src/sbbs3/main.cpp
Log Message:
request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass those values back to request_telnet_opt() with no side effect.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/277855436d2143b88bd9a501
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix crash when NO_EVENTS option is set for terminal server

Don't deref that null pointer

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/26886a8c7ba879f2e84d2650
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove ssh_errors variable.

We're carefully counting the errors, but never looking at the count.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/89a884e9dca8116090df2d87
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the error description upon failure to send on socket

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f83b805f2ebdc68d7612ab6d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't try to renaming a bad (unpackable) REP packet if it doesn't exist

There still appears to be some race condition with network (Samba) FS
directory caching and opening/locking of files, so it does seem illogical that the packet file wouldn't exist at this point (since we have the lock file opened) but this does still happen on occasion on Vertrauen.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/65ff68a0bb3386cd6d4c3fab
Modified Files:
src/sbbs3/main.cpp
Log Message:
Always unlock nodefile_mutex before calling errormsg()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net