1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 16, 2024 18:45:13
    https://gitlab.synchro.net/main/sbbs/-/commit/0b1b1a6fa46caa05d7bd5239
    Modified Files:
    src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c
    Log Message:
    Fix issue with "Pause Logging" buttons not staying pressed in sbbsctrl-win32

    Reported by Max (WESTLINE)...

    Introduced in commit 63d0772d, since we are now calling the set_state() callback periodically, and in sbbsctrl, it sets/resets the pause button
    checked (depressed) state in response to this callback (should it?), this was resetting the pause button checked/depressed state peridically (at the configured sem file check interval, default 2 seconds).

    The fix: if the new server state is the same as the previously set server state, don't call the set_state() callback. I considered this as a potential optimization when I first wrote that commit, but didn't see any obvious downside to calling the set_state() callback redundantly. Now that I see a downside, let's implement this saving/checking of the state to avoid
    redundant "set" calls.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Max@VERT/WESTLINE to Rob Swindell (on Windows on Wednesday, January 17, 2024 12:27:56
    Re: src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c
    By: Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Tue Jan 16 2024 15:45:13

    Fix issue with "Pause Logging" buttons not staying pressed in sbbsctrl-win32

    it's working fine now again, but you forgot terminal server window not working yet.

    /Max

    ---
    þ Synchronet þ Pepzi - Pepzi.se - 1000/1000 MBits
  • From Digital Man@VERT to Max on Wednesday, January 17, 2024 16:40:24
    Re: src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c
    By: Max to Rob Swindell (on Windows on Wed Jan 17 2024 09:27 am

    Re: src/sbbs3/ftpsrvr.c mailsrvr.c services.c websrvr.c
    By: Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Tue Jan 16 2024 15:45:13

    Fix issue with "Pause Logging" buttons not staying pressed in sbbsctrl-win32

    it's working fine now again, but you forgot terminal server window not working yet.

    Ah, thanks, I forgot to commit *.cpp along with the *.c files. Oops.
    --
    digital man (rob)

    This Is Spinal Tap quote #31:
    Viv Savage: Quite exciting, this computer magic!
    Norco, CA WX: 60.5øF, 66.0% humidity, 7 mph W wind, 0.00 inches rain/24hrs
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net