https://gitlab.synchro.net/main/sbbs/-/commit/86ed87d53c89abd5e9b38c2e
Modified Files:
src/doors/clans-src/src/alliance.c defines.h deserialize.c deserialize.h empire.c game.c ibbs.c mail.c makefile myopen.c myopen.h pawn.c pcedit.c reset.c scores.c serialize.c trades.c user.c village.c voting.c src/doors/clans-src/test/village.dat
Log Message:
First pass at serdes

Still not complete, but still compiles. ;)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d432b308fb663108f1da6d62
Modified Files:
src/doors/clans-src/src/alliance.c class.c door.c empire.c fight.c ibbs.c items.c langcomp.c language.c mail.c makefile mcomp.c myopen.c npc.c pcedit.c quests.c reset.c scores.c spells.c trades.c user.c voting.c
Log Message:
And now the fseek()/fread()/fwrite()s.

There's an outside chance it works now.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3e154e3c091b13684063824f
Modified Files:
src/doors/clans-src/src/alliance.c
Log Message:
Fix filename case issue

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7d8b3fec34491ee148af620a
Modified Files:
src/doors/clans-src/src/alliance.c alliance.h chew.c clans.c door.c door.h empire.c empire.h game.h ibbs.c items.c mail.c maint.c menus.c menus2.c npc.c scores.c system.c user.c user.h village.c
Log Message:
Cleaning up code smells... alliance.c

The next load of commits will all be code smells... I'm going through
the files one at a time and addressing (at least):

- Sort includes
- Move extern declarations to headers
- Mark functions static if not used elsewhere

These changes should get less big as they go on

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1fd15471400e61637f73edf5
Modified Files:
src/doors/clans-src/src/alliance.h chew.c clansini.c clansini.h class.c class.h cmdline.c config.c crc.c crc.h defines.h deserialize.h door.c door.h empire.c empire.h fight.c fight.h game.c game.h gum.h ibbs.c ibbs.h input.h interbbs.h items.c items.h k_classes.h k_items.h k_npcs.h k_spells.h language.c language.h mail.c mail.h menus.c menus.h menus2.c misc.h myibbs.c myopen.h news.h npc.c npc.h parsing.h pawn.c quests.c quests.h reg.c reg.h reset.c scores.c scores.h serialize.h snipfile.h spells.c spells.h structs.h system.c system.h tasker.h tslicer.h unix_wrappers.h user.c user.h video.h village.c village.h voting.c
Log Message:
Code smells:

clansini.c, class.c, cmdline.c, config.c, crc.c, deserialize.c, and
door.c

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5a7cd92e7e18a5aa46e25217
Modified Files:
src/doors/clans-src/src/alliance.c chew.c clans.c clansini.c class.c class.h config.c deserialize.c deserialize.h
Log Message:
Play with IWYU a bit

Not exceited to follow through with the whole thing though, but may
as well commit what I've done.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ee927ea87667f9919d178dfd
Modified Files:
src/doors/clans-src/src/alliance.c clans.c door.c empire.c game.c ibbs.c items.c mail.c maint.c menus.c menus2.c npc.c pcedit.c scores.c structs.h system.c user.c village.c
Log Message:
We don't need to malloc() Game, just put it in BSS.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/12591995495995b3740ec78d
Added Files:
src/doors/clans-src/src/alliancem.c alliancem.h
Modified Files:
src/doors/clans-src/docs/ibbs-notes.txt src/doors/clans-src/src/GNUmakefile alliance.c alliance.h empire.c ibbs.c mail.c maint.c menus.c pcedit.c reset.c user.c
Log Message:
Clean up alliances

Move menu "stuff" into new alliancem.c leaving just shared things
in alliance.c, which we can now use from reset and pcedit instead
of copy/pasting the functions. KillAlliances() still needs to move.

Create FreeAlliances() and DeleteAlliance() so callers don't need
to free() alliance data themselves.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2032da3333d935e7a34421d5
Modified Files:
src/doors/clans-src/src/alliancem.c alliancem.h menus.c
Log Message:
Move duplicated code into KillAlliance()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ab1464547fa66f4e2494a9d5
Modified Files:
src/doors/clans-src/src/alliance.c clans.vcxproj clans.vcxproj.filters ibbs.c langcomp.c langcomp.vcxproj langcomp.vcxproj.filters mcomp.vcxproj mcomp.vcxproj.filters pcedit.vcxproj pcedit.vcxproj.filters reset.vcxproj reset.vcxproj.filters system.c system.h video.h win_wrappers.h
Log Message:
Make MSVC happy

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7751a1b3dab47cd10ab57db5
Modified Files:
src/doors/clans-src/src/alliancem.c clans.c clans.props clansini.c config.c ecomp.c empire.c help.c ibbs.c input.c install.c items.c makenpc.c mclass.c mcomp.c mitems.c mspells.c myopen.c npc.c pcedit.c quests.c readcfg.c reg.c reset.c semfile.c system.c unix_wrappers.h user.c video.c wb_fapnd.c win_wrappers.h
Log Message:
Start of move to a coherent strategy.

1) If there's a standard C API, use it (the stuff in wb_fapnd.c will fillany get replaced).
2) If it can't be done with the standard library, prefer a POSIX one (as that's also a standard)
3) When neither apply, and Windows has an API, use the Windows one with a prefix

So most of this is just adding an _ prefix to POSIX functions on Windows, but _stricmp() (MS extension) is now strcasecmp() (POSIX standard).

This will likely fail the pipes, I'll fix the *nix builds momentarily.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2279cc7ca8cfbd15a5eda930
Modified Files:
src/doors/clans-src/src/alliancem.c clansini.c game.c ibbs.c mail.c myibbs.c myopen.c news.c pawn.c readcfg.c reset.c scores.c unix_wrappers.c unix_wrappers.h user.c village.c wb_fapnd.c win_wrappers.h
Log Message:
Fix share modes and eliminate POSIX file accesses

The SH_DENY* macros have been deprecated in favour of _SH_DENY*
ones, so we'll use those everywhere.

Also, the last argument to _fsopen() is not a set of bitflags, it's
manifest constants, so fix _fsopen() on *nix.

Finally, eliminate open()/read()/write()/close() in favour of the
C standard stream interface. It was only used in a couple places,
and there's no need to wrap those on Windows.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/96091c55c79f9a83515f948d
Modified Files:
src/doors/clans-src/src/alliancem.c alliancem.h chew.c config.c crc.c crc.h deserialize.c door.c ecomp.c myopen.c myopen.h structs.h
Log Message:
Fix -Wconversion warnings, phase 1

From a*.c to ecomp.c

Most of these are trivial, but ecomp.c got a lot of extra bounds and
error checking... hopefully the data files don't require buffer
overflows to work!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/543d24cd2b74a293de77f763
Modified Files:
src/doors/clans-src/src/alliancem.c deserialize.c empire.c ibbs.c ibbs.h input.c input.h install.c items.c items.h langcomp.c mail.c makenpc.c makepak.c mclass.c serialize.c structs.h
Log Message:
Fix -Wconversion warnings, phase 4

Hacking away... mostly casts and range checking, but likely not
enough range checking.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/795d49db834714a83416e00f
Modified Files:
src/doors/clans-src/src/alliancem.c mail.c village.c wb_fapnd.c
Log Message:
A few more bugs, memory leak, some double-fclose(), and OOB reads

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/266e85b24c208799d32da358
Modified Files:
src/doors/clans-src/src/alliancem.c clans.c door.c empire.c event.c fight.c ibbs.c items.c mail.c menus.c menus2.c npc.c pawn.c quests.c spells.c trades.c user.c user.h village.c voting.c
Log Message:
Move PClan out of the heap.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1fd095e8bceac19e8a89be41
Modified Files:
src/doors/clans-src/src/alliance.c alliance.h alliancem.c alliancem.h empire.c menus.c pcedit.c system.c user.c
Log Message:
Handle Alliances with a global/Init()/Close() like other data

This constant malloc/read/free is pretty silly.
This still needs to be tested.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/04856e14d79d744995cf4333
Modified Files:
src/doors/clans-src/src/alliancem.c fight.c input.c input.h items.c items.h menus2.c pawn.c user.c video.c video.h
Log Message:
Some small helper functions for inventory

This eliminates the extra Init/Close, and greatly cleans up item
handling code everywhere.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c1c21c7fd70af6808a5f71dd
Modified Files:
src/doors/clans-src/src/alliancem.c empire.c quests.c user.c user.h voting.c
Log Message:
Pass string size into GetClanNameID()

Anything that used it has been broken for a while, truncating to
sizeof(char*)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d93bbe674f7ac09932a1a106
Modified Files:
src/doors/clans-src/src/alliance.c
Log Message:
Alliances is a global now, remove the local version.

Fixes new crash in reset.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net