https://gitlab.synchro.net/main/sbbs/-/commit/01c085136ff935c4b0731ace
Modified Files:
src/doors/clans-src/src/empire.c ibbs.c
Log Message:
Ok, that's got all the encrypted read/writes...

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1bb7e30b72c84f291ad5ae73
Modified Files:
src/doors/clans-src/src/ecomp.c langcomp.c makenpc.c
Log Message:
Fix some memory errors.

Definately broken was popssibly looking at the bytes before a string
for newlines to strip.

Broken depending on implementation was some strcpy() with overlapping buffers... the result is undefined, so who knows?

Hopefully this will fix the macOS build.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/906a93e542228986d25f1ec6
Modified Files:
src/doors/clans-src/src/ecomp.c langcomp.c mail.c video.c
Log Message:
Fix all the sizeof(&Buffer) stuff from overflow fixes

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c1820d521f2f8634b92f49c1
Modified Files:
src/doors/clans-src/src/empire.c
Log Message:
Explicitly handle some impossible cases

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5ea02d6be196147df62418de
Modified Files:
src/doors/clans-src/src/empire.c empire.h input.c input.h myopen.c myopen.h serialize.c
Log Message:
Fix -Wconversion warnings, phase 2

empire.c

This one was rife with potential integer overflow if the input
variables were large enough. I've just increased the size of the
types used until everything would fit, so there's some int64_t in
the API now.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ba51b62f04fc25d2cd87fa41
Modified Files:
src/doors/clans-src/src/empire.c fight.c game.c ibbs.c items.c mail.c menus.c pawn.c scores.c spells.c user.c village.c voting.c
Log Message:
"Fix" language file handling

The strings file has sprintf() format specifiers for the 16-bit MS-DOS
version. Since every parameter is implicitly converted to an int, this
isn't an issue for chars, shorts, int16_t, or uint16_t (the old int
and unsigned). However, some of the format specifiers want longs,
and those values are no longer a long type (they're int32_t). This
caused various numbers to be displayed incorrectly even though the
game used them correctly.

So, I went through and added casts to the type specified in the
strings file to every snprintf() that uses numbers (or chars).
This meant looking up the macro in mstrings.h, then looking at the
referenced line in string.txt... a lot.

Anyway, looks good now.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/42f666a094c434bd9524f4e2
Modified Files:
src/doors/clans-src/src/empire.c fight.c menus2.c pawn.c quests.c spells.c user.c village.c
Log Message:
Some more type fixes to make GCC warnings happy

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/952438b9364a7b1fccef92c8
Modified Files:
src/doors/clans-src/src/empire.c
Log Message:
Trim army size during maintenance

There's various ways to increase your army above the size of your
barracks. Rather than add checks to all those places, just handle
it during maintenance... if your army won't fit in your barracks,
turn those without beds back into followers.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net