https://gitlab.synchro.net/main/sbbs/-/commit/62852439c523e1d09e6b10b1
Modified Files:
src/sbbs3/logfile.cpp
Log Message:
Don't log errno value and description as part of ERROR log msg, when 0

If errno is 0, it's definitely no proividing anything of value here. Of
course, sometimes errno might be non-zero and still be unrelated to the error message. <shrug>

For Nelgin:
!ERROR 0 (Success) in exec.cpp line 644 (js_execfile) compiling "something.js" access=0
<nelgin> I don't quite get why a successful execution is logged as an error

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1fecea061764630c37d903bc
Modified Files:
src/sbbs3/logfile.cpp
Log Message:
Fix extra line feed (and blank line) when long (> 78 char) strings were logged

to node.log via sbbs_t::log()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5f89c517d8d4a1b65f1de4bd
Modified Files:
src/sbbs3/logfile.cpp
Log Message:
De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity

... from ERROR to WARNING, so the repeats won't be logged to error.log file
and won't (normally) be sent as notifications (e.g. emails) to the sysop. The duplicates are identified as from the same source file and line number as the immediately previous logged error within the last 12 hours. String comparison doesn't really work for deduplication since if you look closely, the errors usually are *not* exact duplicates (i.e. there's a node number or a socket descriptor or something that uniquely identifies the user/client/session). Repeated errors don't increment the node's error counter either.

This does not de-duplicate errors logged via other means (e.g. direct calls to log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
solve the majority of duplicate errors that can be logged from the terminal server.

So this at least partially addresses issue #619.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net